removed skip_redirect param from password_reset() and from cgiapp_prerun(), also removed redirect url on 1st login from cgiapp_prerun() - both seem to be superfluous, only need to override default /login/hello rm if 'destination' set in login(), otherwise app handles all redirects correctly; 15 new 01login.t tests for testing behaviour of redirects; 3529 tests, all pass
replaced request_status_view with request_history in crons to try and prevent mysql error apparently from rsv - shown as broken in table check on live HILIS server but not on Deb7-PC - possibly due to /tmp capacity exceeded for temp table
cgiapp_prerun() skips redirect for report notification request; new report_notification search function; function for user to register for report notifications; moved DBIxSimple::dump_query to Local::Utils for sharing with Local::DB; get_practitioner_by_code() now shared with report_notification so loads speculatively; replaced report_available_notification.pl queries with new Local::DB::insert_or_update_if_greater
bugfixes - changed submission of final diagnosis to always require reason for diagnosis change (was optional but missing value caused data commit to die); password_reset() tests for new_passwd_data before using in 'eq' - could be undef due to session deletion
patched cgiapp_prerun to accept skip_redirect flag created during reset password using emailed link, so destination=change_password happens without re-direct; changed M::Roles::ResultsUpdate::history_params attr from lazy_build to std method - was not appropriate to have lazy_build & 'clear' for method called from within loop
reporting function issues diagnosis revision alerts; replaced all controller calls to authen->store->fetch('yooza_profile') and session->dataref->{UserProfile} with LIMS::user_profile() function; L::Local::Mail::_verify_service_status() requires 'devel' or 'prod' ROSEDB_DEVINIT flags to permit email sending