removed skip_redirect param from password_reset() and from cgiapp_prerun(), also removed redirect url on 1st login from cgiapp_prerun() - both seem to be superfluous, only need to override default /login/hello rm if 'destination' set in login(), otherwise app handles all redirects correctly; 15 new 01login.t tests for testing behaviour of redirects; 3529 tests, all pass
LIMS::login - replaced global destination_url (which was never used after re-authentication) with whitelisted GET urls which are safe to use as re-direct in either initial login or re-authentication after session timeout; enabled email_reports.pl to replace mail_reports.pl; report_available_notification.pl - added is_active to contact address query
bugfix to genomics_xml.pl, pdf's need to be transferred in binary mode, ascii_mode flag now only passed to ftp_file() for xml files; collecting destination_url info in login function to see if it's safe to use for idle timeout where it's not currently used; report notification only loads GMC number text box if user has nhs.net email address
replaced request_status_view with request_history in crons to try and prevent mysql error apparently from rsv - shown as broken in table check on live HILIS server but not on Deb7-PC - possibly due to /tmp capacity exceeded for temp table
bug fixes for report_available_notification.pl - col names used in data retrieval query need to match request_notification table (ie use aliases); adapted script to use Getopt::Std & changed to same units as ; changed request_notification table to MyISAM (doesn't need FK constraint)
cgiapp_prerun() skips redirect for report notification request; new report_notification search function; function for user to register for report notifications; moved DBIxSimple::dump_query to Local::Utils for sharing with Local::DB; get_practitioner_by_code() now shared with report_notification so loads speculatively; replaced report_available_notification.pl queries with new Local::DB::insert_or_update_if_greater
adapted email_contacts table to accept department code and report status values (setup/schema/email_reports.sql); redesigned mail_reports.pl -> email_reports.pl to allow multiple departments per hospital/organisation (not supported by mail_reports), and department and report status info now derived from email_contacts tbl, not hard-coded into script; reverted genomics_2016_1222.xsd to original, added new xsd; replave UCLH reporting SOP; updated some tests with year change or change of html tag
adapted email_contacts table to accept department code and report status values (setup/schema/email_reports.sql); redesigned mail_reports.pl -> email_reports.pl to allow multiple departments per hospital/organisation (not supported by mail_reports), and department and report status info now derived from email_contacts tbl, not hard-coded into script; reverted referrer_department => {updated some tests with year change or change of html tag
