NCRS data feed update

Fix perlcritic issues and update build files. Add test for HMDS::Perl

new error code detail text box for request errors

RfC330L - link to new function (FluidX storage DNA concentration file upload

tidy up

Bristol ICE script: * adapt to take 0 days as command-line arg * provide list of locations not org_code * generate query through SQLA to avoid need for placeholders * move hl7 connection params to config file

add 3 new data items to genomics_data.pl; change die command to ok() for yml file check

patches to support Debian 9 test server * replaced hard-coded wkhtmltopdf-<version> with wkhtmltopdf (symlink) as only loaded once for entire app * added return 0 if undefined \$user_location to avoid apache log warnings on non-logged-in user * added block to ftp genomics_transfer.log to main xml_transfer.pl script (no longer need Deb6 curl hack) * lims.fcgi accepts CENTRE arg for use with apache mod_fcgid

replace print-run skip_paper_reports.yml with email_contacts table so that single data source used for print_run.pl, email_reports.pl and HILIS PrintRun functions

increased max length of error code to 4 chars; updated genomics_cancer_v3 with v3.2 changes (incomplete); amended date & datetime placeholders on results entry page to match expected data format; updated Makefile.PL & module_build.pl

retired 'Outreach' screening term and replaced with separate outreach categories (ready to switch off auto-screening Outreach); stopped retrieveing outreach data in C::Report::outreach as it's (re)fetched in downstream load() function; defined pnh, hiv, outreach & molecular screening terms as global vars in Model::Audit - easier to amend categories; new simple SQL search field Request Notes

replaced 'email_from' config var with 'service_email' globally (except within unused functions)

bugfix to report notifications - leading 'C' now optional

Major update to print run function: * print run returns single pdf instead of html page, to allow individual report page headers and numbers * avoided breaking section summaries across new page in report * moved report page numbering to footer.html * expanded horizontal space for "Amended report by" details * fixed error in PDF::WebKit->configure options format Other updates: * exempted print_run from Devel::Cycle code block in devel mode (already exempt in deployment) * debug() returns undef instead of '0' so .tt doesn't display return value * stopped logging process_size in QueryLog - was activated by script errors * moved notification about danger of using 2nd tab for record update to top of file * fixed time zone setting in new message notification log (was not allowing for BST) * fixed error in chart loading function, now only loads in required lab section instad of all Fix added 7th Nov: * added NCH PNH (PB) to turnaround times audit category (was included in PB category)

fixed RDBO error msg if sample_linkage_form select submitted empty; put xml validation into genomics_xml.pl with admin notification of failure; added validation tests to genomics.t