added more testing for specimens in new_request - still have issue with null entry in request_specimen table; new request validation forces specimen code to uppercase; gallium trial script tweaks; t/test-lib.pl switches off foreign_key_checks before re-building tables
added RIE/SMS logger; patched M::Request::new_request() to catch empty @specimens array; minor tweaks to outreach path_request_forms; updated Makefile.PL with deps
patched C::Search::do_search() & M::Request::get_request_id() to capture undef request_id error - occured when request_specimen entry was empty (should be impossible)
completed outreach overdue pack notification function; moved logic to skip if notification already sent from template to model; separated outreach worklists from other worklists; switched off PDS lookup for test scripts; patched validation_profiles/admin.t consistent with change to username validation
MAJOR CHANGE: moved sql_lib() from M::Base to new M::Role::Query; moved all M::R::QueryFormatter methods into M::R::Query; removed sql_lib() from ScriptHelpers - using new M::Roles::Query method; removed lims_dbix() from M::Base - now loaded via M::Role::DBIxSimple on demand; moved get_sql_with_constraint() from M::R::DBIxSimple to M::R::Query; method gets dbh from lims_db not lims_dbix in M::LabSection::update_lab_sections() & M::Specimen::update_specimens(); added elements() to Local::QueryLibrary
fixed M::Request::get_new_and_relapsed_cases() to correctly handle org_code as scalar or arrayref; simplified print-run section to retrieve request ids from excluded locations; refactored & speeded up some slow audit queries
patched M::Request::get_print_run_request_ids() to pass 'sort_by' to _print_run_restricted(), and cloned args to prevent RDBO modification of original hashref 'sort_by' param persisting
changed print-run model logic to speed up slow initial request count - separated restrictions on locations into a separate query in M::Request::get_print_run_request_ids()
excluded exempt nhs number categories from M::Audit::nhs_number_supplied(); changed M::R::DBIxSimple::constraint (Str) to ::constraints(Array) to handle multiple constraints; included a skip list in mail_reports.pl; placed constraints list in forms in toggleviw container
trivial change to C::Test::test_error(); ErrorHandler only sends email if ROSE_DEVINIT set to production db; mail_reports.pl retrieves request data object stashed in RecordHandler::_format_report() instead of calling Request model again - can now introduce skip rules eg on screening term if required
M::Request::new_request() should not require auto_screen_config to save form_data - needed in HistoryAction regardless of auto_screen function; other minor bugfixes
