Preparation for Deb9 migration: adapt tests to run on new deployment (not Deb9 specific) new test file for required file & db resources disable 'Dummy' driver for CAP::Authentication - caused fatal errors when session did not match username in dev env
adaptations for request form access by non-logged-in user * generate 'centre' token in login() for use in request-form url * adapt create_form_tokens() to accept 'centre' only * Local::Utils encrypt & decrypt functions capture Crypt::CBC errors & return empty not stacktrace
changed report_available_notification.pl to determine whether notice is new or an update from time of authorisation not request status; commented dump_query in cml_rq_pcr_monitoring.pl
removed skip_redirect param from password_reset() and from cgiapp_prerun(), also removed redirect url on 1st login from cgiapp_prerun() - both seem to be superfluous, only need to override default /login/hello rm if 'destination' set in login(), otherwise app handles all redirects correctly; 15 new 01login.t tests for testing behaviour of redirects; 3529 tests, all pass
LIMS::login - replaced global destination_url (which was never used after re-authentication) with whitelisted GET urls which are safe to use as re-direct in either initial login or re-authentication after session timeout; enabled email_reports.pl to replace mail_reports.pl; report_available_notification.pl - added is_active to contact address query
bugfix to genomics_xml.pl, pdf's need to be transferred in binary mode, ascii_mode flag now only passed to ftp_file() for xml files; collecting destination_url info in login function to see if it's safe to use for idle timeout where it's not currently used; report notification only loads GMC number text box if user has nhs.net email address
cgiapp_prerun() skips redirect for report notification request; new report_notification search function; function for user to register for report notifications; moved DBIxSimple::dump_query to Local::Utils for sharing with Local::DB; get_practitioner_by_code() now shared with report_notification so loads speculatively; replaced report_available_notification.pl queries with new Local::DB::insert_or_update_if_greater
Major update to print run function: * print run returns single pdf instead of html page, to allow individual report page headers and numbers * avoided breaking section summaries across new page in report * moved report page numbering to footer.html * expanded horizontal space for "Amended report by" details * fixed error in PDF::WebKit->configure options format Other updates: * exempted print_run from Devel::Cycle code block in devel mode (already exempt in deployment) * debug() returns undef instead of '0' so .tt doesn't display return value * stopped logging process_size in QueryLog - was activated by script errors * moved notification about danger of using 2nd tab for record update to top of file * fixed time zone setting in new message notification log (was not allowing for BST) * fixed error in chart loading function, now only loads in required lab section instad of all Fix added 7th Nov: * added NCH PNH (PB) to turnaround times audit category (was included in PB category)
