refactored report_notification block for improved clarity; permitted designation now defined in config files; allows user to set notifications inactive

replaced 'email_from' config var with 'service_email' globally (except within unused functions)

bugfix to report notifications - leading 'C' now optional

added ability for user to update report status (new/all) for report notifications; request_details (clinical details field) is an optional or required field delegated to config; mail_rports.pl now replaced by email_reports for UCLH & Leeds; preserve line-breaks for patient notes display

removed skip_redirect param from password_reset() and from cgiapp_prerun(), also removed redirect url on 1st login from cgiapp_prerun() - both seem to be superfluous, only need to override default /login/hello rm if 'destination' set in login(), otherwise app handles all redirects correctly; 15 new 01login.t tests for testing behaviour of redirects; 3529 tests, all pass

replaced request_status_view with request_history in crons to try and prevent mysql error apparently from rsv - shown as broken in table check on live HILIS server but not on Deb7-PC - possibly due to /tmp capacity exceeded for temp table

report notification admin functions

cgiapp_prerun() skips redirect for report notification request; new report_notification search function; function for user to register for report notifications; moved DBIxSimple::dump_query to Local::Utils for sharing with Local::DB; get_practitioner_by_code() now shared with report_notification so loads speculatively; replaced report_available_notification.pl queries with new Local::DB::insert_or_update_if_greater

new HMRN referral pathway; added possible new diagnoses to diagnosis email alerts; new trial overrides in activity data function

fixed bug in forgotten password function - required authen_username not username, so password reset link could never have worked

patched all M::Email::send_message() returns to handle Return::Value object instead of string/undef

bugfixes - changed submission of final diagnosis to always require reason for diagnosis change (was optional but missing value caused data commit to die); password_reset() tests for new_passwd_data before using in 'eq' - could be undef due to session deletion

patched cgiapp_prerun to accept skip_redirect flag created during reset password using emailed link, so destination=change_password happens without re-direct; changed M::Roles::ResultsUpdate::history_params attr from lazy_build to std method - was not appropriate to have lazy_build & 'clear' for method called from within loop

moved reset password message to template

bugfixes