RfC450 - incomplete requests function * move clinical trials from screening term to separate section * move queries to SQL::Abstract (request_ids query needed 2 multi-placeholders)
simplified layout of incomplete_requests.pl for clarity - easier to see what happens under ; bugfix to _get_authorised_requests() in incomplete_tests.pl where empty arrayref would kill query; minor adjustment to storage racks read_xtr_96.tt display
bugfix - failure to update request_result_summary timestamp col on result_summary update causing premature locking of records; action logged in request history when request status set to complete by incomplete_requests.pl or M::R::RequestUpdate::update_request_status; adapted incomplete_requests.pl to include status complete requests with diagnosis awaiting final diagnosis/review; ScriptHelpers::do_request_history renamed to log_diagnosis_alert to avoid conflict with M::R::HistoryAction method of same name; nav bar loads HMRN link if user has either view_outreach_data or edit_outreach_data permissions; L::Role::DiagnosisConfirm::diagnosis_confirmation_required hash of lab_sections renamed from %map to %required for clarity
modified method of determining whether C::Worklist::display() is for data entry and how return is handled; incomplete_requests have date stamp; awaiting_final_diagnosis list includes diagnosis = awaiting final review
logic to determine whether to set request status to complete considers result summary datetime relative to authorisation datetime; replaced io unlink() with system unlink in render_pdf - was giving occasional errors; replaced M::Base::does_authorisation method with Moose attr to save repeat db queries; fixed oversight in _archive_report_details() causing history log to record amended specimen_date at every authorisation; gallium_data.pl checks for comment field to prevent fatal error; more report_status.t tests to test for status change on delayed result summary entry
incomplete_requests script includes reporter/authorisor info; new_national_code script patched to skip instances of requests where new referrer registered then amended on same day
refactored L::Utils::get_yaml to only require args needed for construction of path/to/yaml_dir/filename to remove duplication from components requiring a get_yaml_file() method (Controllers, Model & ScriptHelpers)
moved diagnosis_confirmation_required from Local::Utils to new Local::Role::DiagnosisConfirm - didn't belong in Utils class, and function now needs to access LIMS config to load yaml files dir dynamically depending on CENTRE env param