RfC450 - incomplete requests function * move clinical trials from screening term to separate section * move queries to SQL::Abstract (request_ids query needed 2 multi-placeholders)
bugfix - failure to update request_result_summary timestamp col on result_summary update causing premature locking of records; action logged in request history when request status set to complete by incomplete_requests.pl or M::R::RequestUpdate::update_request_status; adapted incomplete_requests.pl to include status complete requests with diagnosis awaiting final diagnosis/review; ScriptHelpers::do_request_history renamed to log_diagnosis_alert to avoid conflict with M::R::HistoryAction method of same name; nav bar loads HMRN link if user has either view_outreach_data or edit_outreach_data permissions; L::Role::DiagnosisConfirm::diagnosis_confirmation_required hash of lab_sections renamed from %map to %required for clarity
logic to determine whether to set request status to complete considers result summary datetime relative to authorisation datetime; replaced io unlink() with system unlink in render_pdf - was giving occasional errors; replaced M::Base::does_authorisation method with Moose attr to save repeat db queries; fixed oversight in _archive_report_details() causing history log to record amended specimen_date at every authorisation; gallium_data.pl checks for comment field to prevent fatal error; more report_status.t tests to test for status change on delayed result summary entry
added new function to require confirmation when reporting with outstanding test results; moved C::Report::_get_requested_tests() to C::Roles::ResultHandler; converted some template data objects to as_tree hashrefs to prevent db lookups when empty; fixed some tests to comply with new confirm_outstanding_results flag
QueryLog BEGIN block looks for ENV var ROSEDB_DEVINIT = devinit_prod to load Dispatch::File::Rolling - previous method looked for devinit_devel & loaded Dispatch::File, otherwise Dispatch::File::Rolling. This failed in test suite if rolling sql.log already created for current date, with 644 permissions for Apache user. Now test suite and dev server both use same log files, and rolling log files only used by Apache user
screening functions (new & edit; not yet auto-screen at new request) display outcome summary of which lab-tests requested & which (if any) skipped; fixed many *.t issues caused by adding patient notes form to report page - made 'report' a multi-form page
patched C::Screen::edit() to use same screening function as used at initial screen; fixed a lot of failing tests due to new screening functions - report_status.t still failing